search

noaignite / accelerator

A collection of NoA Ignite packages
12 stars 3 forks source link

fix/react utils/bundle true #199

Closed adamsoderstrom closed 4 weeks ago

adamsoderstrom commented 1 month ago

Prior to this commit, we've had an issue where directives like "use client" gets stripped out of the chunk-* files created in the dist folder, when specifying bundle: true in tsup.config.ts. I tried to trace this issue and found a corresponding one in the esbuild repo (0). In that, i found that @Seojunhwan had created a ESBuild plugin (1) that resolves this issue. Though, as of this writing, the plugin doesn't support single-quote directives, which we have in our repository. I forked the repo and submitted a PR for that (2). Until then, i've published my fix under my personal namespace and use it here.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 3d2c3391787bb03628f6c3cdae209308e0e23f24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @noaignite/react-utils | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR