Expose `calculateContrast`, `calculateLuminance` and `hexToRGB` utility functions

noaignite / accelerator

A collection of NoA Ignite packages

12 stars 3 forks source link

Expose `calculateContrast`, `calculateLuminance` and `hexToRGB` utility functions #227

Open adamsoderstrom opened 1 week ago

adamsoderstrom commented 1 week ago

feat(utils): expose calculateLuminance to consumer of package
feat(utils): expose calculateContrast to consumer of package
feat(utils): expose hexToRGB to consumer of package
docs(changeset): Expose calculateContrast, calculateLuminance and hexToRGB utility functions

fixes #205

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 4f44f4eff5263b8fce91718607dea997730edb87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | -------------------------------- | ----- | | @noaignite/utils | Minor | | @noaignite/react-centra-checkout | Patch | | @noaignite/tailwind-typography | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

maeertin commented 5 days ago

Nice job @adamsoderstrom :) Do we feel the need to write tests for these functions or is it good enough that colorContrast which uses them all has its test?

adamsoderstrom commented 4 days ago

Nice job @adamsoderstrom :) Do we feel the need to write tests for these functions or is it good enough that colorContrast which uses them all has its test?

I do think that we shouldn't implicitly rely on tests on other functions.

I could write the tests according to the examples! 😊