Open Dashice opened 1 week ago
I'm not too fond of adding this hook for a few reasons, that being:
getElementById
which alters/disregards Reacts design choice for this decision.querySelector('[id="${reactId}"]')
.useId
hook giving the impression of this hook being a patched version.If we do feel the need for a useId
hook with functionality to prefix/suffix I would suggest going for a hook that is called just that. For example usePrefixedId
.
What are your thoughts @adamsoderstrom @Dashice ?
⚠️ No Changeset found
Latest commit: 2b337735dbead01578e80b0e74ccbbcacdf1a73b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver typesClick here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR