Closed ErezBiren closed 1 year ago
@noam-honig Noam Honig
@ErezBiren
@ErezBiren
- Love the map
- The tabs - not so much :) how about changing them to something more subtle in the bottom bar, next to the "more resutls in english" button - something that when you show a list it'll offer a map and vice versa?
- Can you take a look at new-look #11 and let me know if you think we should merge that look?
Note that I've merged the new look and feel, so merge it to your work
On Mon, Mar 20, 2023 at 3:41 PM Erez Birenholz @.***> wrote:
@ErezBiren https://github.com/ErezBiren
Love the map
The tabs - not so much :) how about changing them to something more subtle in the bottom bar, next to the "more resutls in english" button - something that when you show a list it'll offer a map and vice versa?
Can you take a look at new-look #11 https://github.com/noam-honig/wikiloc/pull/11 and let me know if you think we should merge that look?
Thanks
sure thing, I'll do that.
looks pretty cool.
— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/10#issuecomment-1476257029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU3JFO6I32RSY6WLDI3W5BM77ANCNFSM6AAAAAAWA6FZBU . You are receiving this because you were mentioned.Message ID: @.***>
@noam-honig fixed
Please test the show map on mobile - I'm worried that it'll clash with the up arrow button that is there
And let me know once it's ready for merge.
Just making sure you've marked this pull request as a "draft" pull request, so it doesn't mark it as ready for merge
Would you like for me to merge it?
@noam-honig - It indeed clashes with the arrow button what would you like to do with that?
אני אסדר את זה - חוץ מזה אפשר למזג?
אני אסדר את זה - חוץ מזה אפשר למזג?
כן
אתה גם מקבל את השגיאה הזו בDEV?
Add tab control at the top, so we can choose list view or map view.