noam-honig / wikiloc

11 stars 8 forks source link

Add map view #10

Closed ErezBiren closed 1 year ago

ErezBiren commented 1 year ago

Add tab control at the top, so we can choose list view or map view.

image

ErezBiren commented 1 year ago

@noam-honig Noam Honig

noam-honig commented 1 year ago

@ErezBiren

  1. Love the map
  2. The tabs - not so much :) how about changing them to something more subtle in the bottom bar, next to the "more resutls in english" button - something that when you show a list it'll offer a map and vice versa?
  3. Can you take a look at #11 and let me know if you think we should merge that look?
ErezBiren commented 1 year ago

@ErezBiren

  1. Love the map
  2. The tabs - not so much :) how about changing them to something more subtle in the bottom bar, next to the "more resutls in english" button - something that when you show a list it'll offer a map and vice versa?
  3. Can you take a look at new-look #11 and let me know if you think we should merge that look?
  1. Thanks
  2. sure thing, I'll do that.
  3. looks pretty cool.
noam-honig commented 1 year ago

Note that I've merged the new look and feel, so merge it to your work

On Mon, Mar 20, 2023 at 3:41 PM Erez Birenholz @.***> wrote:

@ErezBiren https://github.com/ErezBiren

  1. Love the map

  2. The tabs - not so much :) how about changing them to something more subtle in the bottom bar, next to the "more resutls in english" button - something that when you show a list it'll offer a map and vice versa?

  3. Can you take a look at new-look #11 https://github.com/noam-honig/wikiloc/pull/11 and let me know if you think we should merge that look?

  4. Thanks

  5. sure thing, I'll do that.

  6. looks pretty cool.

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/10#issuecomment-1476257029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU3JFO6I32RSY6WLDI3W5BM77ANCNFSM6AAAAAAWA6FZBU . You are receiving this because you were mentioned.Message ID: @.***>

ErezBiren commented 1 year ago

@noam-honig fixed

image

noam-honig commented 1 year ago

Please test the show map on mobile - I'm worried that it'll clash with the up arrow button that is there

And let me know once it's ready for merge.

noam-honig commented 1 year ago

Just making sure you've marked this pull request as a "draft" pull request, so it doesn't mark it as ready for merge

Would you like for me to merge it?

ErezBiren commented 1 year ago

@noam-honig - It indeed clashes with the arrow button what would you like to do with that?

image

noam-honig commented 1 year ago

אני אסדר את זה - חוץ מזה אפשר למזג?

ErezBiren commented 1 year ago

אני אסדר את זה - חוץ מזה אפשר למזג?

כן

noam-honig commented 1 year ago

אתה גם מקבל את השגיאה הזו בDEV? image