search

noam-honig / wikiloc

11 stars 8 forks source link

Figure out the user's language and use it for wiki #16

Closed ErezBiren closed 1 year ago

ErezBiren commented 1 year ago

Related to #1

noam-honig commented 1 year ago

I'm not sure this is enough to get this to work for more languages.

I personally use an english iphone but want the hebrew version of these results.

Localizing the app, would require making more changes.

I think we should park this for now, and see what users may ask - what do you think?

ErezBiren commented 1 year ago

Maybe we should add a settings page so the user can change it. we could solve it with a simple combo for choosing the language in the main page but I think it will make the main page looks too loaded

noam-honig commented 1 year ago

Not sure - I like the simplicity of the site.

I think that at first stage, to target only hebrew speaking users is ok

On Tue, Mar 21, 2023 at 11:58 AM Erez Birenholz @.***> wrote:

Maybe we should add a settings page so the user can change it.

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/16#issuecomment-1477552008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PUYTJUGY76WZ5Z4CI7DW5F3ULANCNFSM6AAAAAAWCDYOHY . You are receiving this because you commented.Message ID: @.***>

ErezBiren commented 1 year ago

That's fine with me.