search

noam-honig / wikiloc

11 stars 8 forks source link

New version to the project - Breaking changes !!! #24

Closed develad closed 1 year ago

develad commented 1 year ago

19

Hey everyone!

I want to present you an update that I've been working on. This version of the project containing Routing system. It's not done yet.. But it gives a good feel of it

NOTE: This version is build on top of previous commit (ced3b37f78490c703a3daf4c05f7f4de8950f0f0) so there maybe bug fixes required

The changes that were made:

  1. Adding react-router-dom for a better navigation
  2. Removing excess code in the index.html file. Leaving the meta data in the head for better SEO
  3. Creating file structure in the src folder
  4. Changing the CSS style in some places

Things that should be done next or haven't completed:

  1. Connecting the MAP page @ErezBiren
  2. Creating the context store file in TS. I think it would be better to implement all of the project logic in one location instead of prop-drilling @noam-honig
  3. Adding some NavBar (As suggested in the issue attached)
  4. Converting all CSS files to SCSS and continue styling the site for a good feel and look
  5. Have a beer 🍺

Take a look around and tell me what you think

Happy Coding

ezgif com-optimize

develad commented 1 year ago

Here are some screenshot from the latest update:

localhost_5173_wikiloc_map(iPhone X) localhost_5173_wikiloc_list(iPhone X) (2) localhost_5173_wikiloc_list(iPhone X) (1) localhost_5173_wikiloc_list(iPhone X)

@noam-honig If you can please make the latest commit a code review 🐱‍👓

noam-honig commented 1 year ago

@develad love the progress!!!

Can you please merge master into your branch, and resolve the conflicts? that way we'll be able to later merge it fully in.

Also - let me know once you're done and you want me to review it.

Best

develad commented 1 year ago

@develad love the progress!!!

Can you please merge master into your branch, and resolve the conflicts? that way we'll be able to later merge it fully in.

Also - let me know once you're done and you want me to review it.

Best

@noam-honig Hey Noam,

You have a GO on the review Check the pull request #25