noam-honig / wikiloc

11 stars 8 forks source link

useEffect refactoring & useLocation hook #3

Closed drormaman closed 1 year ago

drormaman commented 1 year ago

It's my first open source contribution, would love to here comments on this.

Thanks

noam-honig commented 1 year ago

Thank you so much for contributing. Personally, I believe that refactoring to hooks or extracting urls to external functions is something that I do when I need to use them in more than one place.

If I only use it in one place, then the separation between multiple files makes it harder for me to grasp the totality of what's going on.

Please don't let this discourage you from making more changes to the code - take a look at the issues, I'm sure you can take one of them and apply it.

noam-honig commented 1 year ago

How about taking a shot at #5