search

noam-honig / wikiloc

11 stars 8 forks source link

Auto scroll #37

Closed develad closed 1 year ago

develad commented 1 year ago

Added results auto-fetching when the user is in the bottom of the result entry list

noam-honig commented 1 year ago

Please format the. Ode usin prettier, so there’ll be changes and it’ll be consistent to the code

develad commented 1 year ago

Hi Noam, I've tried my best to set the prettier settings to be consistent with the code. Anyway check the functionality and tell me what you think? Yay 🎉 or Nay 👎?!

noam-honig commented 1 year ago

I see now that I didn't have prettier configured correctly - that's on me.

Did you test the functionality well? can I just merge it? (

On Sun, Jul 30, 2023 at 1:38 PM Elad Bar @.***> wrote:

Hi Noam, I've tried my best to set the prettier settings to be consistent with the code. Anyway check the functionality and tell me what you think? Yay 🎉 or Nay 👎?!

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/37#issuecomment-1657104265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU75EV5UE2RDZLWLNJLXSY2UDANCNFSM6AAAAAA24XJJZM . You are receiving this because you commented.Message ID: @.***>

develad commented 1 year ago

I've test it... It's working... You have a green light from me. But it would be better if you take a look first before merging... just to get the feel of it. I think it's a nice touch to be added to the site :)

noam-honig commented 1 year ago

Merging it - if anything goes wrong we'll be able to fix it

noam-honig commented 1 year ago

Note - that the auto scroll - scrolls everything up - I think it hinders a bit the experience.

Also - test it with different Geo locations where there are less results

develad commented 1 year ago

Thanks for the merge! 👍

I know it scroll everything up. I've designed it specifically that way. there are results added to the list every time there is a fetch request and those results are combined to the list by the sorting. I wanted the user to see them by scrolling back the list from the top. A little bit clunky solution but it works.

Note - that the auto scroll - scrolls everything up - I think it hinders a bit the experience.

Also - test it with different Geo locations where there are less results

noam-honig commented 1 year ago

I think that only in the first time it adds items on top (English results) later it adds all around

On Sun, Jul 30, 2023 at 14:48 Elad Bar @.***> wrote:

Thanks for the merge! 👍

I know it scroll everything up. I've designed it specifically that way. there are results added to the list every time there is a fetch request and those results are combined to the list by the sorting. I wanted the user to see them by scroll back the list.. A little bit clunky solution but it works)

Note - that the auto scroll - scrolls everything up - I think it hinders a bit the experience.

Also - test it with different Geo locations where there are less results

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/37#issuecomment-1657118520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU5XLCYMT4XKQCNTAILXSZCYHANCNFSM6AAAAAA24XJJZM . You are receiving this because you modified the open/close state.Message ID: @.***>

noam-honig commented 1 year ago

Or maybe we should just start always with hebrew and english at the same time - and then we don't have to scroll up

On Sun, Jul 30, 2023 at 2:54 PM noam honig @.***> wrote:

I think that only in the first time it adds items on top (English results) later it adds all around

On Sun, Jul 30, 2023 at 14:48 Elad Bar @.***> wrote:

Thanks for the merge! 👍

I know it scroll everything up. I've designed it specifically that way. there are results added to the list every time there is a fetch request and those results are combined to the list by the sorting. I wanted the user to see them by scroll back the list.. A little bit clunky solution but it works)

Note - that the auto scroll - scrolls everything up - I think it hinders a bit the experience.

Also - test it with different Geo locations where there are less results

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/37#issuecomment-1657118520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU5XLCYMT4XKQCNTAILXSZCYHANCNFSM6AAAAAA24XJJZM . You are receiving this because you modified the open/close state.Message ID: @.***>

develad commented 1 year ago

I think it would be a great and quick fix solution. That way the user can choose which of the results is the most suitable for him/her and the scrolling that trigger the fetching action will happened in the background (aka: Infinite Scroll... sort of) Maybe later on we can add a dedicate button to filter the results between languages (En/He)

Or maybe we should just start always with hebrew and english at the same time - and then we don't have to scroll up … On Sun, Jul 30, 2023 at 2:54 PM noam honig @.> wrote: I think that only in the first time it adds items on top (English results) later it adds all around On Sun, Jul 30, 2023 at 14:48 Elad Bar @.> wrote: > Thanks for the merge! 👍 > > I know it scroll everything up. I've designed it specifically that way. > there are results added to the list every time there is a fetch request and > those results are combined to the list by the sorting. I wanted the user to > see them by scroll back the list.. A little bit clunky solution but it > works) > > Note - that the auto scroll - scrolls everything up - I think it hinders > a bit the experience. > > Also - test it with different Geo locations where there are less results > > — > Reply to this email directly, view it on GitHub > <#37 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AD65PU5XLCYMT4XKQCNTAILXSZCYHANCNFSM6AAAAAA24XJJZM > . > You are receiving this because you modified the open/close state.Message > ID: @.***> >

noam-honig commented 1 year ago

In most places there are few Hebrew results, so you usually need also the English.

On Mon, Jul 31, 2023 at 08:56 Elad Bar @.***> wrote:

I think it would be a great and quick fix solution. That way the user can choose which of the results is the most suitable for him/her and the scrolling that trigger the fetching action will happened in the background (aka: Infinite Scroll... sort of) Maybe later on we can add a dedicate button to filter the results between languages (En/He)

Or maybe we should just start always with hebrew and english at the same time - and then we don't have to scroll up … <#m5786199403792083868> On Sun, Jul 30, 2023 at 2:54 PM noam honig @.> wrote: I think that only in the first time it adds items on top (English results) later it adds all around On Sun, Jul 30, 2023 at 14:48 Elad Bar @.> wrote: > Thanks for the merge! 👍 > > I know it scroll everything up. I've designed it specifically that way. > there are results added to the list every time there is a fetch request and > those results are combined to the list by the sorting. I wanted the user to > see them by scroll back the list.. A little bit clunky solution but it > works) > > Note - that the auto scroll

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/37#issuecomment-1657691972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU6UBKK3PURUP7LGOWTXS5CHPANCNFSM6AAAAAA24XJJZM . You are receiving this because you modified the open/close state.Message ID: @.***>

develad commented 1 year ago

I agree