search

noam-honig / wikiloc

11 stars 8 forks source link

Adding new ArrowUp component for smooth scrolling up the page #9

Closed develad closed 1 year ago

develad commented 1 year ago

localhost_5173_wikiloc_(iPhone X) (1)

noam-honig commented 1 year ago

@develad Can you take a look at #11 and let me know if you think we should merge that look?

noam-honig commented 1 year ago

Note that on light mode it looks a bit bad - can you improve it?

image

develad commented 1 year ago

Sure. It's an easy fix

noam-honig commented 1 year ago

@develad any chance you would also like to do #12 ?

noam-honig commented 1 year ago

Note that on light mode it looks a bit bad - can you improve it?

image

Also - on iphone with light mode - it displays only a black circle.

And you need to click it twice to scroll up

develad commented 1 year ago

Also - on iphone with light mode - it displays only a black circle.

And you need to click it twice to scroll up

About the bugs on iPhone I really don't know what seems to be the reason for it. Maybe it would be best to open a 'Bug issue' about it?

noam-honig commented 1 year ago

Fixed it.

Care to think of a Better ui for the bottom bar?

On Mon, Mar 20, 2023 at 18:01 Elad Bar @.***> wrote:

Also - on iphone with light mode - it displays only a black circle.

And you need to click it twice to scroll up

About the bugs on iPhone I really don't know what seems to be the reason for it. Maybe it would be best to open a 'Bug issue' about it?

— Reply to this email directly, view it on GitHub https://github.com/noam-honig/wikiloc/pull/9#issuecomment-1476508548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD65PU3HQSLLJJA75VKP7FTW5B5MNANCNFSM6AAAAAAWA4FRF4 . You are receiving this because you modified the open/close state.Message ID: @.***>