search

noamross / quickscraper

An R package wrapping quickscrape, a node.js web scraper
MIT License
16 stars 2 forks source link

Move node.R functions into independent package #2

Open noamross opened 10 years ago

noamross commented 10 years ago

If this package is CRAN-able, it will make node dependencies much easier for other packages.

karthik commented 10 years ago

I'd be interested in this since I'm developing something else node based and would prefer to avoid duplication. Is there an ETA for this?

noamross commented 10 years ago

I could aim for the end of next week, post-ESA and a few other things.

On Wednesday, August 13, 2014, Karthik Ram notifications@github.com wrote:

I'd be interested in this since I'm developing something else node based and would prefer to avoid duplication. Is there an ETA for this?

— Reply to this email directly or view it on GitHub https://github.com/noamross/quickscraper/issues/2#issuecomment-52126435.

karthik commented 10 years ago

Fantastic! That timeline would be great. Thanks! :+1:

karthik commented 10 years ago

Hi @noamross, No rush whatsoever but would you kindly drop me a note when this is ready to use? In the meantime I have rolled everything you wrote into rDat so I can begin testing but will swap it out with an Import when ready.

cheers, - K

noamross commented 10 years ago

@karthik, First version is at https://github.com/noamross/rnodejs, with a modified version of rDat using it at https://github.com/noamross/rDat. Definitely some outstanding issues still. I hope rDat development will provide a good test and chance to smooth out the API.

karthik commented 10 years ago

Thanks Noam, I'll add it in Can you tell me what's different in your rdat fork? Might be better as a PR for now, than continue dev on a fork, since I expect my repo to change a good bit over the coming weeks.

On Fri, Aug 29, 2014 at 12:07 PM, Noam Ross notifications@github.com wrote:

@karthik https://github.com/karthik, First version is at https://github.com/noamross/rnodejs, with a modified version of rDat using it at https://github.com/noamross/rDat. Definitely some outstanding issues still. I hope rDat development will provide a good test and chance to smooth out the API.

— Reply to this email directly or view it on GitHub https://github.com/noamross/quickscraper/issues/2#issuecomment-53917821.

noamross commented 10 years ago

Here's the PR, with details: https://github.com/ropensci/rDat/pull/1