Improvements

[zhuxb711]

1. Removed unnecessary lock in some functions
2. Upgrade to latest dependency
3. Upgrade to .Net 7.0
4. Optimize the GetNextQueue and AddOrUpdate to make it faster
5. Clean up the code to fix .Net Analyzers's error
6. Add Equals overrides on TimeToProcess class to fix the failure on GenericPriorityQueueUnitTests

[zhuxb711]

@noamyogev84 Hi please help review the PR and let me know if have any concerns, thanks! It would be great if you could merge this PR and publish a new version to nuget🙂

[zhuxb711]

@noamyogev84 Hi I updated the code and replied your comments, please help review it again, thanks! 😃

[zhuxb711]

@noamyogev84 Hi! Could please take a look at the changes and maybe approve this PR? Thanks and very appreciate!

[noamyogev84]

Thanks @zhuxb711 wonderful work 🎉

[zhuxb711]

Thanks for your approval, but there are some problems in the workflow file, I have updated them to make sure the repo could be built with the latest .Net 7.0, and make I request another approval to run the flow again? Thanks~~😁😎

[zhuxb711]

Thanks! @noamyogev84 Glad to hear that the PR was merged, thanks again and hopefully we could found the new version on nuget soon~ Your repo is the best ConcurrentPriorityQueue implementation I have ever seen. Looking forward to your new nuget package~

[noamyogev84]

Thanks @zhuxb711, I really enjoyed reviewing your code 🎉 From now on - Our repo.

Regarding Nuget: I will have to make some time for this in the coming weeks. 🙏 I encourage you to maybe think of a pipeline/action/automated release for Nuget releases and implement in here

[zhuxb711]

You could use this action for nuget release. Since it needs your nuget key and you should place it in your action secret. It would be better let you handle this action.

https://github.com/brandedoutcast/publish-nuget

[zhuxb711]

But maybe you could upload a new nuget package manually first so that we will not wait too long~~

[noamyogev84]

Yo, Nuget 2.0.0 published. 🎉

On Wed, Jan 11, 2023 at 6:43 PM Ruofan @.***> wrote:

But maybe you could upload a new nuget package manually first so that we will not wait too long~~

— Reply to this email directly, view it on GitHub https://github.com/noamyogev84/ConcurrentPriorityQueue/pull/19#issuecomment-1379130851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26MJPIZJNWSGOAATJ7KS3WR3PMNANCNFSM6AAAAAATMYBF7A . You are receiving this because you were mentioned.Message ID: @.***>

[zhuxb711]

@noamyogev84 I got 1.0.0 from nuget still......Anything wrong?

[noamyogev84]

something went wrong working on it

On Tue, Jan 17, 2023 at 10:18 AM Ruofan @.***> wrote:

[image: image] https://user-images.githubusercontent.com/42038175/212844824-9fcb0a93-2e97-4f55-a626-7bc118677d9a.png

@noamyogev84 https://github.com/noamyogev84 I got 1.0.0 from nuget still......Anything wrong?

— Reply to this email directly, view it on GitHub https://github.com/noamyogev84/ConcurrentPriorityQueue/pull/19#issuecomment-1385004353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26MJMUQJPQ3MAA3PZ7CITWSZIWDANCNFSM6AAAAAATMYBF7A . You are receiving this because you were mentioned.Message ID: @.***>

[noamyogev84]

Done

On Tue, Jan 17, 2023, 18:12 Noam Yogev @.***> wrote:

something went wrong working on it

On Tue, Jan 17, 2023 at 10:18 AM Ruofan @.***> wrote:

[image: image] https://user-images.githubusercontent.com/42038175/212844824-9fcb0a93-2e97-4f55-a626-7bc118677d9a.png

@noamyogev84 https://github.com/noamyogev84 I got 1.0.0 from nuget still......Anything wrong?

— Reply to this email directly, view it on GitHub https://github.com/noamyogev84/ConcurrentPriorityQueue/pull/19#issuecomment-1385004353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB26MJMUQJPQ3MAA3PZ7CITWSZIWDANCNFSM6AAAAAATMYBF7A . You are receiving this because you were mentioned.Message ID: @.***>