noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
618 stars 39 forks source link

Allow relative units in height #107

Closed mariomui closed 1 year ago

mariomui commented 1 year ago

When not using px the number will automatically be px When using a vh vmin or any uom, banner will automatically use uom. The goal is to allow people who detach views to new windows to savely use banners.

Also, included prettierrc to mimic your style but make the formatting consistent. Just so there are no arguments over styling.

Implications: i tested on chrome responsiveness. I have not tested on Android or PC.

git-obsidian-banners-feat-relative-height-UMID-9018c61b-3bdb-4355-bec5-0d855b0f91f2

noatpad commented 1 year ago

(Closing PR due to rewrite) But also I took the opportunity to implement relative units to be taken for banner height settings during the rewrite, so thank you for laying out the groundwork!