search

noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
616 stars 39 forks source link

Type Mismatch on "banner_header" key #121

Closed Aeases closed 11 months ago

Aeases commented 12 months ago

The automatic header filename uses a boolean, where as the custom name uses a string, could cause incompatibilities with the upcoming obsidian databases & gives you a ugly (kinda nice looking) warning symbol depending on whether your first banner header was a filename or a custom one.

image

One solution could be to just use a word like "filename" to trigger the automatic header, could allow the user to change that in setting too

noatpad commented 12 months ago

That's true actually. I forgot about the upcoming database changes would probably require properties to be consistent with their types. For the time being, I think using an empty string could also work to trigger the automatic filename

Aeases commented 11 months ago

Yea that sounds like a better solution, great this will be fixed b4 it's out of beta!

noatpad commented 11 months ago

All good to go in https://github.com/noatpad/obsidian-banners/releases/tag/2.0.2-beta! An empty (or rather null) value will now trigger the auto filename insertion