noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
616 stars 39 forks source link

Checklists are messed up in 2.0.5-beta #136

Open davidolrik opened 11 months ago

davidolrik commented 11 months ago

Funny bug, every item in checklists now have a header injected.

I have set "Display header by default" to on, and every note with a checklist now also have the header injected. Turning "Display header by default" off makes the extra headers go away.

Setting banner_header manually does not cause extra headers in the checklists.

Asetnozama commented 11 months ago

I can confirm this issue

Also the dataview tables are messed up.

Issue appears on pc and mobile

(I use minimal theme)

noatpad commented 11 months ago

Oh that is a funny bug, hah.

I can't seem to replicate it on my end. Can you send an example of this occuring?

davidolrik commented 11 months ago

Ah, I found the cause of the issue - it's a conflict with the Tasks plugin.

Here is what it looks like:

CleanShot 2023-10-15 at 23 35 34@2x

Turning the Tasks plugin off, removes the extra titles.

Asetnozama commented 11 months ago

It's not only with the task plugin. Also the dataview tables look like this. With the previous version of banners there's no problem

Asetnozama commented 10 months ago

Any update about this issue?

DesertDwarf commented 8 months ago

I had the same issue with only three plugins installed: Banners, Dataview, and Homepage. If I have the Banner Header feature enabled in 2.0.5-beta, the value I supplied for the banner header in the config populates some inline dataview code with that header. If I use the banner_header property (and make sure the value is no longer specified in the config), then the header is not interspersed with the dataview output.

If you're playing with these, make sure to go away from that note and then back again to verify the change worked. I forgot to do that and I thought @davidolrik's suggestion wasn't working until I remembered to have it refresh the page.

samirasoto commented 7 months ago

Also having this issue. Will probably just revert back to 2.0.3 or 2.0.4 for now.