noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
618 stars 39 forks source link

Banner titles #84

Closed LostPaul closed 1 year ago

LostPaul commented 1 year ago

image

New/Edited features

Bug fixes

Now the icon/title has almost the same height in reading and source mode

Old

https://user-images.githubusercontent.com/70213368/210142632-095cb27a-3911-44f8-beeb-c02d0c5f4a40.mp4

New

https://user-images.githubusercontent.com/70213368/210142862-eec09a2b-0b1f-4ad1-ae88-439173f55251.mp4

Banner dragging bug

Old

https://user-images.githubusercontent.com/70213368/210148435-f17c0a1a-fdc2-45ee-b238-ea63d7a77287.mp4

New

https://user-images.githubusercontent.com/70213368/210148539-fd2a573b-acda-4d0b-a6c4-135972aae71c.mp4

bcwilsondotcom commented 1 year ago

👍 Would love to see this get merged.

LucEast commented 1 year ago

Yo Bro, I don't think that the owner of this plugin still develop it. Maybe publish your own community plugin of this version. We need someone who actively commits and updates.

mariomui commented 1 year ago

i disagree with not having a proper dist folder for pumping out to distribution. is this obsidian requirement to pump out artifacts into root?

noatpad commented 1 year ago

Closing this PR due to the complete 2.0 rewrite. Pardon me that I didn't get the chance to review and see if this can be merged before, but as I did the rewrite, I took into consideration your banner title implementation for the "headers" part of v2, so thank you very much for your contribution to add those headers into Banners