search

noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
618 stars 39 forks source link

Twemoji fail to load from maxcdn.com #88

Open xmacex opened 1 year ago

xmacex commented 1 year ago

The plugin tries to load Twemojis from maxcdn.com. No such domain exists, and I see a Failed to load resource: net::ERR_NAME_NOT_RESOLVED DNS error in the developer console. Maybe MaxCDN went bust or was acquired by some powergrabbing hegemonic megacorp?

For instance banner_icon: 🗓 tries to load a calendar icon from https://twemoji.maxcdn.com/v/13.1.0/72x72/1f5d3.png. That URL gives this

Ie nothing. In context:

Screenshot 2023-01-15 at 12 10 44

So maybe replace Twemoji base-url with another, existing CDN provider, or consider shipping the icon set locally (also for less creepy data tracking).

Klemet commented 1 year ago

Having the exact same issue; I agree that shipping twemojis would do be great, especially to keep with the offline possibilities of Obsidian.

xmacex commented 1 year ago

Woopsie today there is a HTTP 301 redirect to jsdelivr.net, e.g. the aforementioned https://twemoji.maxcdn.com/v/13.1.0/72x72/1f5d3.png → https://cdn.jsdelivr.net/gh/twitter/twemoji@v13.1.0/assets/72x72/1f5d3.png.

Maybe this is a non-issue?

joseub71 commented 1 month ago

Hello, how can I help ?

I have the same problem :( I can colaborate whit code, how is the process ?