search

noatpad / obsidian-banners

An Obsidian plugin that adds banners to your notes
MIT License
634 stars 41 forks source link

Banner covers content when moving to new window #99

Open wordrevel opened 1 year ago

wordrevel commented 1 year ago

In the default Obsidian window, the banner looks great and takes up the space determined in the settings:

Screenshot 2023-03-30 at 17 46 53

However, when I open a page with the banner embed in a new window, the banner expands to cover the page content:

Screenshot 2023-03-30 at 17 47 05 Screenshot 2023-03-30 at 17 47 16

This is particularly a problem when working with more than one monitor because panes can't expand across screens, so new windows must be opened.

How can this issue be resolved, so that banners work normally in new windows too?

riverLethe9 commented 1 year ago

I am having the same issue. When I drag a file which has a banner to a new window, it takes up the whole window and I cannot interact with elements at the top of the file.

I am using Obsidian 1.3.5 and Banners 1.3.3

https://github.com/noatpad/obsidian-banners/assets/29024715/a706aa24-53f6-46e0-befe-49f871708930

Nick-de-Bruin commented 1 year ago

I was having the same issue. From what I could find the --banner-height variable isn't found in the undocked windows. A quick fix would be adding a CSS snippet with the following:

body {
  --banner-height: 250px; 
}

This partially fixes the issue. You still won't be able to drag the banner to change its relative position, though.

suhaylmv commented 9 months ago

@Nick-de-Bruin Thanks!