search

noatpad / typora-theme-ursine

A Typora theme, inspired by Bear
MIT License
715 stars 86 forks source link

Table formatting is unpleasant at max-width 700px #33

Closed krokofant closed 3 years ago

krokofant commented 5 years ago

I agree on the stylistic choice for keeping the editor small (#25) but this can easily look bad for tables (which are intended to display data...).

The columns can't be especially wide at all before the columns start collapsing. image

max-width: 1000px image

Could we make it look okay excluding the table from the current max-width?

noatpad commented 5 years ago

Mmm, thing is that if I remove the max-width of tables, they could be instead too big, especially if the app is in full-screen mode. Increasing the max-width would make more sense to me, like the example you've shown by increasing just that. The max-width: 1000px actually plays really nicely with tables, so I'd go with that.

But there is a bit of a problem because of how elements are structured in Typora. In the app, every paragraph, header, table, etc. are in a #write container, which is the one in charge of setting the width and max-width, thus affecting every element. There are probably ways around that for a single child, but I might have to change from a single parent having those properties to every child those properties instead, which could bring up other problems, but we'll see.

krokofant commented 3 years ago

@aCluelessDanny Should we just close this? 🙂 Sizing every child element to work around table sizes doesn't seem like an ideal solution.