noatpad / typora-theme-ursine

A Typora theme, inspired by Bear
MIT License
715 stars 86 forks source link

Diagram background color causes text to be unreadable (Umbra, Linux) #38

Closed Prometheus625 closed 4 years ago

Prometheus625 commented 4 years ago

image

krokofant commented 4 years ago

@Prometheus625 Are there more graph scenarios that look weird? Would be great to have a few more test cases.

Prometheus625 commented 4 years ago

The flowchart using flowchart.js and the sequence diagram using js-sequence both look normal. It's the mermaid charts that are strange.

Here's the example sequence diagram using mermaid: image

Graph using mermaid: image

Gantt using mermaid: image

I don't know much about CSS but was able to find that changing --node-fill fixed the problem. Adding --node-fill:#1e2022; to urisine-umbra.css in :root{} worked.

Here's the mermaid flowchart after: image

noatpad commented 4 years ago

Huh that's interesting. Looks like Typora uses mermaid's hardcoded, default colors. A few extra CSS rules and a bit of tinkering with those root variables oughta do the trick

image
noatpad commented 4 years ago

And Gantt diagrams should look a lot better now once I get a release up

image image