noatpad / typora-theme-ursine

A Typora theme, inspired by Bear
MIT License
715 stars 86 forks source link

Greek fonts look weird #45

Closed spirosag closed 4 years ago

spirosag commented 4 years ago

Hi, Unfortunately greek fonts look very weird, with wonky letters. I tried both the cyrillic and the regular version. If you plan on fixing them I can give you screenshots of what's wrong just tell me!

Thanks for a great theme! πŸ‘πŸ‘πŸ‘

noatpad commented 4 years ago

Ah, please do! It could be the font not supporting it, but it's best if I can see what looks funny about it.

I actually forgot about up pushing some fixes for a while, so now's a good time to see if I can add one more in there before another release.

spirosag commented 4 years ago

2020-01-13 10_02_19-Untitledβ€’ - Typora

As you can see there is quite the difference between the greek and the engllish font. Also some greek words (like Ο€, ΞΌ) appear like they are in a different font. This is with the regular theme not the cyrillic.

Tell me if you need more.

noatpad commented 4 years ago

Yeah, it's what I thought, both fonts are mostly incompatible with Greek in general. A few of those words (like the Ο€ & ΞΌ that you mentioned) happened to be compatible since they have a few uses in other languages.

Probably the best thing to do is to make a "Greek" release pack with fonts that are compatible with the language. I did some digging to find fonts that are compatible and similar enough to the ones the theme uses, so mind if you can check if these are good (and also try testing them in the site just in case, haha)?

Headers would use the Roboto Slab font and paragraphs would use the Open Sans one. The monospace/code font should still be good to use here

spirosag commented 4 years ago

I think they would work. πŸ‘ I tested them a bit with some greek text that was looking weird previously. If you release such a greek release let me know and I'll test it more.

noatpad commented 4 years ago

So a bit of fiddling later, and this is about as close as I can get to make the look similar while keeping it Greek-compatible.

The left shows the original font, while the right has the greek-safe ones (it also happens to also support Cyrillic and Vietnamese, so that's a bonus)

image

I'm gonna try to get the release out before dusk, so give it a try once that's up & tell me if it works out alright~

spirosag commented 4 years ago

I think it looks pretty good. With a quick look could'nt find anything wrong. I'll let you know if I stumble on any more incosistencies. Closing this and thanks again! πŸ™πŸ”₯🀟