28 shooting screen - Githubissues

nobelization / panoramax-mobile-app

GNU Affero General Public License v3.0

35 stars 7 forks source link

28 shooting screen #34

Closed OtterWays closed 6 months ago

OtterWays commented 6 months ago

I modified the UI according to the mockups provided.

It is now impossible to take photos in portrait mode and the buttons have been redone for landscape mode.

The burst mode is not yet implemented and will be in #33

OtterWays commented 6 months ago

Changes ok for me, can you please correct the E2E tests performed during the CI ?

I have added a tooltip to the photo capture button. However, it is not an actual button but a GestureDetector. Consequently, the test 'iShouldSeeAButtonNamed($, 'Take a picture');' does not work. I don't want to delete this test, but I'm unsure how to modify it to make it pass.

OtterWays commented 6 months ago

@luifr10 I I am unable to fix the integration test.

luifr10 commented 6 months ago

@OtterWays don't worry, I'll take a look

luifr10 commented 6 months ago

I just realized that the behavior of the capture page has changed aha. When running integration tests, the application defaults to portait mode, so I'm going to make 2 changes:

Add the sentence to change orientation in the uuv_flutter library.
Add a scenario that checks the presence of the message when in portrait mode.

luifr10 commented 6 months ago

Hello @OtterWays !

integration_tests are now OK, here are the changes I've made :

Add a scenario that checks the presence of the message when in portrait mode.
Change last scenario that checks landscape mode
Migrate router from go_router to get_it (easier for testing)
Wrap capture button with IconButton to have semantic role button (for accessibility we have to be careful on this point)

I also made a rebase on the main branch, it's better to do a rebase instead of a merge to update with the main branch.

If it's ok for you, we can merge then