nobiot / md-roam

Use Org-roam with markdown files by adding Md-roam as a plug-in. Mix org and markdown files in a single Org-roam database.
GNU General Public License v3.0
331 stars 14 forks source link

Support for org-roam-db-version version 18 #56

Closed sync0 closed 2 years ago

sync0 commented 2 years ago

First, thank you so much for this package. As a user of Obsidian.md, I am really looking forward to integrating this package into my workflow. Without proper support for a database, Emacs' markdown-mode is just not usable as a Zettelkasten.

I was trying to get md-roam working today, but I noticed that it only supports up to org-roam-db-version 17. Org-roam's (v2.1) current version is 18, so I was wondering if you could add support for this version as well.

Again, thank you so much for this package. The org format is much more powerful than markdown, but the lack of cross-platform support for org files (essentially, you are stuck with Emacs if you want to work properly with them) doesn't accommodate my current Zettelkasten workflow.

nobiot commented 2 years ago

Sure. Db version 18 was introduced only yesterday in my time zone https://github.com/org-roam/org-roam/pull/1963.

This sort of “warning” is exactly the reason for this check.

I’ll review the change and try to support version 18 as soon as I can. Give me some time.

nobiot commented 2 years ago

@sync0 Thank you for the note. Should be fine with the latest commit. Let me know if you have issues.