search

nobiot / md-roam

Use Org-roam with markdown files by adding Md-roam as a plug-in. Mix org and markdown files in a single Org-roam database.
GNU General Public License v3.0
333 stars 15 forks source link

Empty Markdown links trigger 'Args out of range' error #73

Closed gambhiro closed 1 year ago

gambhiro commented 1 year ago

If the .md file contains an empty Markdown link without url (for example from a template file, link waiting to be filled out later)

- [Article Source]()

Then it triggers an error and the file is not parsed.

note.md with error Args out of range: "", 165, 166, skipping...
nobiot commented 1 year ago

I believe it's fixed now. I'd appreciate it if you could try it on your end. Thanks!

gambhiro commented 1 year ago

It works! Thanks for the useful package, it's great to use org-roam and Obsidian together.

nobiot commented 1 year ago

Thank you. I didn’t know you could use Obsidian with md-roam. Wiki links have different syntax, I thought

paladhammika commented 1 year ago

It works! Thanks for the useful package, it's great to use org-roam and Obsidian together.

Ajahn @gambhiro, respectful bump-ins :pray:

Would you be willing to explain here how to integrate org-roam with Obsidian?

nobiot commented 1 year ago

@paladhammika , while we wait, I suggest you could try and see it for yourself. Try setting org-roam-directory to your Obsidian vault folder (one of them if you have many). If I remember correct and things haven't changed on Obsidian, a vault is simply a folder (directory) that contains markdown files. Md-roam/Org-roam should just pick them up.

gambhiro commented 1 year ago

It's quite simple to mix org-roam with Obsidian: the Vault is a sub-folder in the org-roam-directory. Some capture templates create an org-roam .org file, some create an Obsidian .md file. Changing md-roam-regex-aliases as in #43 helps to improve link auto-completion.