turning off the mode should turn off the overlays

nobiot / org-remark

Highlight & annotate text, EWW, Info, and EPUB

https://nobiot.github.io/org-remark/

GNU General Public License v3.0

425 stars 20 forks source link

turning off the mode should turn off the overlays #5

Closed holtzermann17 closed 2 years ago

holtzermann17 commented 3 years ago

Screenshot from 2020-12-27 02-13-13

Screenshot: I just disabled the mode but the overlays remain

shombando commented 3 years ago

@holtzermann17 looks like this is a recognized limitation by the author:

Turning off minor mode does not turn off the highlights

This should not do any harm, but if you are distracted, kill the buffer (not revert) and visit it again. Toggling show/hide of highlights is something I would like to add later.

Would be interesting to prompt the user to reload buffer (at least current buffer) assuming buffer is unmodified when turning off the minor mode.

nobiot commented 2 years ago

v0.0.6 does this. README:

Now turning off minor mode will turn off the highlights It is still recommended to use org-marginalia-toggle to temporarily hide/show highlights. This is because turning off org-marginalia-mode will stop tracking of the locations of highlights in the current buffer. Any (however minor) change will likely result in mismatching the locations of saved highlights and the current buffer’s text content.