nobiot / org-transclusion

Emacs package to enable transclusion with Org Mode
https://nobiot.github.io/org-transclusion/
GNU General Public License v3.0
902 stars 43 forks source link

refactor: Split -add-callback from -add to enable async transclusion #209

Closed josephmturner closed 6 months ago

josephmturner commented 6 months ago

Splitting the org-transclusion-add into two parts enables functions in org-transclusion-add-functions to be asynchronous. With this change, content can be transcluded over a network, using http://, hyper://, or other protocols.

For a proof-of-concept integration with hyperdrive.el, see this file.

ping @alphapapa @tarsius @protesilaos

nobiot commented 6 months ago

@josephmturner Thank you 🙏 Let me take some time before I come back to review the code. The intent sounds very interesting :)

josephmturner commented 6 months ago

Thank you, @nobiot!

The diff is large because of whitespace changes. If you use Magit to review the patch, using (setopt magit-diff-refine-hunk 'all) may help show the significant differences.

josephmturner commented 6 months ago

Thank you!!! Whenever the next version of org-transclusion is released, I'll release a new version of hyperdrive.el! :)