nobiot / org-transclusion

Emacs package to enable transclusion with Org Mode
https://nobiot.github.io/org-transclusion/
GNU General Public License v3.0
902 stars 43 forks source link

Question about org-transclusion-indent-mode #240

Closed akashpal-21 closed 3 months ago

akashpal-21 commented 3 months ago

In the Manual it says that org-transclusion-indent-mode "supports" org-indent-mode. But when I add a transclusion - the indent is maintained properly in org-indent-mode : the only problem is that the fringe overlay is missing - org-transclusion-indent-mode adds support for the fringe overlay not indentation itself -- I think it is confusing in that respect.

Adding a screenrecord to show the difference

https://github.com/nobiot/org-transclusion/assets/46517170/768f67dc-5422-4f55-82bf-073fbe1e9e0b

akashpal-21 commented 3 months ago

Closing -- since not an issue, but simple confusion.

akashpal-21 commented 3 months ago

possible bug?: When undoing there is no way to regain indentation in source without fully closing the file and reopening -- revert buffer doesn't work either

https://github.com/nobiot/org-transclusion/assets/46517170/4762f64b-9e34-42eb-b58f-702dd3cfd463

Any solution? or known limitation.

nobiot commented 3 months ago

I don't seem to be able to reproduce the problem.

In this video, both buffers have org-indent-mode enabled (I don't normally use it). The extension to support it is turned on; that's why you see the vertical bar on the left buffer appear.

https://github.com/nobiot/org-transclusion/assets/12507865/166f1876-3f1f-4b76-9ffc-f4e0e7d2ae31

image Indent-mode support enabled.

image Indent-mode support disabled.

Note the vertical bar on the left side of the left buffer.

akashpal-21 commented 3 months ago

Are you doing 'd' #'org-transclusion-remove

Or 'C-x u' #'undo

The issue happens on undo and not org transclusion remove -- I think emacs simply goes back one step in the undo tree and just deletes it -- I dont know if it can be solved easily, but I have a gut feeling we cannot remove the source fringe trivially on undo.

Org-transclusion-remove works fine -- will use it, non issue.