search

nobiot / org-transclusion

Emacs package to enable transclusion with Org Mode
https://nobiot.github.io/org-transclusion/
GNU General Public License v3.0
938 stars 47 forks source link

fix: cleanup only if there were activated transclusion #95

Closed HyunggyuJang closed 3 years ago

HyunggyuJang commented 3 years ago

Ignoring cleanup process when isn't needed fixes #94.

nobiot commented 3 years ago

Thank you @HyunggyuJang. I don't use latex or preview of it. Does this solve #94 on your end? Regardless of this, I think the change your are proposing makes sense.

One side note. I am considering to contribute this package to Org upstream. I am planning to start a conversation in the mailing list some time this year. This requires all the major contributors to assign copy right to FSF. https://github.com/nobiot/org-transclusion#notes-on-pull-requests-and-fsf-copy-right-assignment

The change your have proposed is a beautiful one-line change -- I really appreciate your effort and time -- from purely the size point of view, I don't believe it requires you to go through this process. Nonetheless, I thought I should let you know of this intention.

Thank you.