search

nobitagit / ng-material-floating-button

Material design floating menu with action buttons implemented as an Angularjs directive.
http://nobitagit.github.io/ng-material-floating-button/
MIT License
464 stars 130 forks source link

Fixed a display bug occurring in Chrome #40

Closed DanielMSchmidt closed 7 years ago

DanielMSchmidt commented 9 years ago

To reproduce open a sample page on chrome and scroll. The UI won't update until you manually trigger a rerender.

Applying this fixed solved the problem.

nobitagit commented 9 years ago

I was actually surprised that I did get away without backface-visibility problems with this. Anyway I tried reproduce this and could not see the issue, can you explain further and help me out with this?

That being said I will quite surely merge your PR, so it's just a matter of myself seeing this issue live. Thanks for the contribution.

DanielMSchmidt commented 9 years ago

I will provide one soon, thanks for merging. One bonus question: Why is the original project not in bower? This way it could be included here in the bower.json and the fix would have been done in the main project where it would belong.

nobitagit commented 9 years ago

I went for including it as a git submodule rather than a Bower dep as I was developing the css at the same time from both repos (mfb and ng-mfb) and submodules are the best way - at least for me - to have a two way data flow and keep everything is sync.

I could both pull changes from mfb to here and push from here to the mfb repo, instead of changing the css in the upstream repo and pull from here every time I needed I tweak. In that sense my suggestion in the readme to edit the CSS code in the original repo is just for practical reasons for me and to keep Issues here only related to Angular, but any code implemented here can be easily transferred from here to Mfb with a simple push.

Now that the code is much more stable it probably makes sense to move it out to Bower, though.

DanielMSchmidt commented 9 years ago

I had the same problem developing the PR (using my original project as base). I found bower link was a really nice solution, behaves like you described the git submodules. just FYI ;)

DanielMSchmidt commented 8 years ago

I assume this PR can be closed?

DanielMSchmidt commented 7 years ago

Closed 1,5 years later due to inactivity