search

noble / bleno

A Node.js module for implementing BLE (Bluetooth Low Energy) peripherals
MIT License
2.12k stars 448 forks source link

Highsierra #360

Closed jacobrosenthal closed 6 years ago

jacobrosenthal commented 6 years ago

Closes #357 #343 #341

Please test.

marcosinigaglia commented 6 years ago

I test on macOS 10.13.2 and is working.

micro23xd commented 6 years ago

macOS 10.13 - Advertising, READ and WRITE requests work fine, NOTIFY does not work for me. tested with LightBlue and nRF connect on iOS.

edit: tested with this example, http://shawnhymel.com/703/bluetooth-low-energy-peripherals-with-javascript/

ecdpalma commented 6 years ago

macOs 10.13.2 - Basic discovery is fine. but READ characteristic fails. Tried with nRF in Android (5.1) and iOS. In Android, code 133 is logged by nRF.

jacobrosenthal commented 6 years ago

@ecdpalma can you enable debug logging for the bindings layer and report back DEBUG=highsierra-bindings node yourscripthere.js

after that try the changes from @micro23xd above

jacobrosenthal commented 6 years ago

Without further reporting from @ecdpalma or anyone else, Im calling this as complete as I can get it. Please merge.

jacobrosenthal commented 6 years ago

Took care of those comments, take a look.

Also I recommend squashing this to 2 commits, Copy yosemite bindings to high sierra stub Change xpcids for high sierra

which I can do if you like.