noble / bleno

A Node.js module for implementing BLE (Bluetooth Low Energy) peripherals
MIT License
2.13k stars 450 forks source link

Support node10 #423

Open rzr opened 5 years ago

rzr commented 5 years ago

Cc: @petersaints

petersaints commented 5 years ago

@rzr I still have to test @abadonaware/noble and this bleno pull request on the project where I'm using them. So far I have been using https://github.com/jrobeson/node-bluetooth-hci-socket/#fix-builds-for-node-10 as a replacement for node-bluetooth-hci-socket, together with noble and bleno packages on the npm registry. I'll try it out soon and I'll give some feedback if everything worked as intended.

zhangyanrui commented 5 years ago

same problem

petersaints commented 5 years ago

There's a fork that uses the @abandonware/node-bluetooth-hci-socket instead of the oficial node-bluetooth-hci-socket package: https://github.com/abandonware/bleno This fork works on Node 10 LTS. Maybe you'll find it useful as I did.

However, I'd still love to see the work that has been done to get noble, bleno and node-bluetooth-hci-socket working under Node 10 LTS merged into the original repository and released on npm.

On Fri, Mar 22, 2019 at 11:01 AM Michael Schwarz notifications@github.com wrote:

An update to Node10 LTS would be great. This would allow me to use Bleno with Node crypto library to establish a secure connection. Crypto has unfortunately very limited possibilities in Node8.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/noble/bleno/pull/423#issuecomment-475577678, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJocgpYqVdGZETgCgS4EDpRm6_0t_-yks5vZLgdgaJpZM4ZcgSV .

rzr commented 5 years ago

Please review, if none, I am considering to release a version of: https://github.com/abandonware/bleno/

on npm too, then track: https://www.npmjs.com/~rzr

rzr commented 5 years ago

This change is released in: https://www.npmjs.com/package/@abandonware/bleno/v/0.5.1-0

rzr commented 3 years ago

Please confirm this issue is resolved with @abandonware version

Relate-to: https://github.com/abandonware/bleno/issues/17