search

noble / node-bluetooth-hci-socket

MIT License
153 stars 188 forks source link

support node 10+ #129

Open sevenbitbyte opened 4 years ago

sevenbitbyte commented 4 years ago

Update nan usage

valpackett commented 4 years ago

Still an error with node 14:

/home/greg/.cache/node-gyp/14.5.0/include/node/v8.h:197:5: error: static_assert failed due to requirement 'std::is_base_of<v8::Context, v8::Object>::value' "type check"
    static_assert(std::is_base_of<T, S>::value, "type check");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/BluetoothHciSocket.cpp:482:18: note: in instantiation of function template specialization 'v8::Local<v8::Context>::Local<v8::Object>' requested here
        obj->Set(obj, Nan::New("devUp").ToLocalChecked(), Nan::New<Boolean>(devUp));
                 ^
adi1525 commented 4 years ago

Thank you! It works on node 10.16.3

You saved me few days for debugging. ;)

Regards, Adrian

elggem commented 4 years ago

It worked on Node 10.22.0! When I finally found this it was like magic. Who can we ping to merge this?

rzr commented 3 years ago

Is this issue also relevant for this release:

https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-6

rzr commented 3 years ago

Feel free to comment this related ticket:

https://github.com/abandonware/node-bluetooth-hci-socket/issues/9