search

nobleo / full_coverage_path_planner

Full coverage path planning provides a move_base_flex plugin that can plan a path that will fully cover a given area
Apache License 2.0
528 stars 147 forks source link

Galactic manual src include conversion #22

Closed cesar-lopez-mar closed 2 years ago

cesar-lopez-mar commented 2 years ago

Core code compiles. Next step is to update the interface of the plugin (Automatic compilation fails because I merged other branches to this one before merging them to galactic, is this a configuration issue?)

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Timple commented 2 years ago

Easiest in these cases is to just continue from the previous branch.

master -> galactic -> cmake-fixes -> manual_src

Everything will compile just fine and the latest and greatest is in the last branch.

You can then create PR's from cmake-fixes to galactic. And from manual_src to cmake-fixes.

If the first PR is merged, the other one will automatically point to galactic and look the same.

cesar-lopez-mar commented 2 years ago

Created a clean branch from galactic and made new PR.