search

nobleo / full_coverage_path_planner

Full coverage path planning provides a move_base_flex plugin that can plan a path that will fully cover a given area
Apache License 2.0
528 stars 147 forks source link

Galactic add nav2 global planner interface #25

Closed cesar-lopez-mar closed 2 years ago

cesar-lopez-mar commented 2 years ago

Plugin interface added. I will test it next week, we can start review. @Timple, perhaps you can add AlaaAlassi to our github so he can help in reviews as well.

Timple commented 2 years ago

@AlaaAlassi is invited.

Will review soon!

cesar-lopez-mar commented 2 years ago

This version already runs with nav2. It seems that the old way to get the map from the server via a service does not work on on nav2. The code will be updated to use the provided costmap in another PR

cesar-lopez-mar commented 2 years ago

Processed all reviews related to the ROS2 conversion. The rest of the comments are aimed at optimizing the existing ROS1 code. I suggest we include those changes in another PR.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication