nobleo / path_tracking_pid

Path Tracking PID offers a tuneable PID control loop, decouling steering and forward velocity
Apache License 2.0
129 stars 37 forks source link

`Controller::getControllerState()` should be refactored #124

Closed lewie-donckers closed 2 years ago

lewie-donckers commented 2 years ago

This function breaks the abstraction and provides way too much detail to the caller. Only a few of its members are actually used by TrackingPidLocalPlanner. The Controller should provide dedicated getters with a higher level of abstraction and proper names.

This will be a lot easier once #123 has been done so the entire state structure does not need to be passed to that function.