nobleo / path_tracking_pid

Path Tracking PID offers a tuneable PID control loop, decouling steering and forward velocity
Apache License 2.0
130 stars 37 forks source link

Calling cancel blocks the controller #88

Open rokusottervanger opened 2 years ago

rokusottervanger commented 2 years ago

A call to cancel should return whether or not the controller implements stopping behavior. If false, the base class handles it (and outputs a zero velocity setpoint right away). Meaning we should not block, but return true immediately, in this case.

Source: https://github.com/magazino/move_base_flex/blob/a5c19cb8f3135679e4f8f36a9ec6123b121d69ab/mbf_abstract_nav/src/abstract_controller_execution.cpp#L257-L259