search

nobleo / rviz_satellite

Display internet satellite imagery in RViz
Apache License 2.0
530 stars 226 forks source link

Tile Loader not showing the tiles in the proper place #48

Closed david-alejo closed 5 years ago

david-alejo commented 5 years ago

Dear all,

First of all, thank you for the development of this plugin that I've found very handy.

I upgraded to the latest version yesterday to make it work in 18.04. I have found that now the satellite images are no longer in the proper placed. Instead, they appear with a small shift to the South and East.

I attach an example with the representation of coordinates 41.38738993 N 2.183433017 E in google maps and with your plugin in rviz to help to understand the differences.

Has any other noticed it? issue_rviz_satellite Screenshot from 2019-03-13 17-44-04

beetleskin commented 5 years ago

Is your robot_frame equal to the frame_id in the NavSat message? What tile-server are you using? Is this also happening with other tile-servers? Did you check the frame-conversion setting?

Could you provide a minimum working example to reproduce, via a PR?

david-alejo commented 5 years ago

Thank you for your kind response. I'm checking the frame_id and if I can't correct it, I will provide a MWE.

Regarding to the tile served, I checked Google Maps and OpenStreetMap.

david-alejo commented 5 years ago

I created a PR related to this issue as a minimum working example. In it, you can see a marker and the axes in the reference frame map. They do not correspond with the location of /gps/fix when using google maps.

beetleskin commented 5 years ago

Well, the demo is currently not working properly, the display produces an error. In your PR, please add

<node pkg="tf2_ros" type="static_transform_publisher" name="static_tf_fake" args="0 0 0 0 0 0 map base_link" /> and set the robot_frame to base_link. And try again.

Can you confirm that this works? If so, this is a duplicate of #49.

david-alejo commented 5 years ago

Interesting. By doing so the tiles are loaded OK.

However, it is not clear why this is necessary. I mean: the plugin was configured to have /map as robot frame, why is it necessary to use the base_link frame?

beetleskin commented 5 years ago

Its not necessary (you can also use the /map frame) - but some frames need to be defined. That's true for most Display plugins, and for RViz itself.

david-alejo commented 5 years ago

Ok it makes sense, I'm closing the issue as it is somehow duplicated with yours.

Thank you for your kind responses. Best regards,

beetleskin commented 5 years ago

@schra maybe this isn a pure duplicate - I think the plugin should complain if frames are missing, rather than rendering bullshit. What do you think?

schra commented 5 years ago

@schra maybe this isn a pure duplicate - I think the plugin should complain if frames are missing, rather than rendering bullshit. What do you think?

Good point. I created an issue for this.