search

nobleo / rviz_satellite

Display internet satellite imagery in RViz
Apache License 2.0
530 stars 226 forks source link

Don't show map if transform is missing #51

Open schra opened 5 years ago

schra commented 5 years ago

If AerialMapDisplay/Status/Transform shows the error Fixed Frame [map] does not exist then the map shouldn't be drawn at all. This leads to confusing results, see #48

beetleskin commented 5 years ago

Could be done by using MessageFilterDisplay, like most display plugins do.

m-naumann commented 5 years ago

I encountered the same while working on #55

The easiest would be to set scene_node->setVisible(false); but the problem I see is that there are cached tiles that are made invisible, and when setting scene_node->setVisible(true); after successful transformations, they are all set to true, so also old/irrelevant tiles are shown.

schra commented 4 years ago

From #72:

When you set an invalid ff, for example "asdfasdfsf", then the map will jump. (It will not jitter, but jump). The status shows that there is an error, but the map is still displayed. I think we should hide the map if the ff is invalid?