search

nobleo / rviz_satellite

Display internet satellite imagery in RViz
Apache License 2.0
545 stars 231 forks source link

Don't show map if transform is missing #52

Closed schra closed 3 years ago

schra commented 5 years ago

Description

It's confusing when the map is shown but the transform is missing. This leads to the map being on a wrong place.

Fixes #51

Test plan

Call roslaunch rviz_satellite demo.launch once with the demo.launch as is and once without the static_tf_fake.

/cc @beetleskin

beetleskin commented 5 years ago

Why not using the MessageFilterDisplay class? This should fix the issue easier, see https://github.com/gareth-cross/rviz_satellite/issues/51#issuecomment-488021188. Using this class will lead to not getting a message-callback, if the frame_id within the message is not available. Unfortunately, this does not produce an error, but the map is not rendered, as we want it to be.

beetleskin commented 5 years ago

hm, actually it should produce errors if tf is not available, if I read this right: http://docs.ros.org/jade/api/rviz/html/c++/message__filter__display_8h_source.html#l00106