search

nobrin / macaron

A simple O/R mapper for SQLite
http://nobrin.github.com/macaron/
MIT License
31 stars 8 forks source link

Wordings could be easier... #38

Open wenzul opened 9 years ago

wenzul commented 9 years ago

I've recently used your orm. Thanks for the smart approach and supporting bottle. I want just give a feedback as a beginner who wants to quick-use it. :) For me I found two obstacles... I need some time to realize that a PrimaryKeyField exists (tried to hack with rowid) and have the name SerialKeyField. Also I don't know, why you rename a common term like commit into bake? One more thing, you should not use a python built-in dict in your code as variable name.

nobrin commented 9 years ago

Hi, Thank you for using macaron and your comment. First, SerialKeyField, I've forgotten the reason of the name...(may be brought up the image of 'serial' in PostgreSQL). And your suggestion of PrimaryKeyField is resonable.

Well, about 'bake()', I completely agree with you! :-P The method has introduced at early time in the development. That's why "Macaron is a baked goods". But this is slightly silly reason ;-). So I will introduce 'commit()' into the macaron.

The dict as variable name is my mistake. It will be fixed too. Thank you for your comment and advices!!