search

nobt-io / frontend

Frontend of nobt.io.
https://nobt.io
GNU General Public License v3.0
10 stars 4 forks source link

Update to react-router-dom v5 #270

Closed thomaseizinger closed 4 years ago

thomaseizinger commented 5 years ago

Version 5 ships with react hooks (f.e. useHistory) that allow us to do all of our routing in a fairly elegant way.

This work should unblock us from implementing the "new payment" page in a reasonable way. It is currently not fully working but I am very close :)

This also allows us to throw away LocationBuilder. In addition (in order to use the new hooks) I had to upgrade many components to function components. In the long run, this should allow us to get rid of the redux store, esp. for things like the create-wizard or the add-bill-form.

thomaseizinger commented 5 years ago

The scrolling restoration doesn't work at the moment. Possible solution: Ditch the automatic scroll restoration and use the pushState API instead of save scroll position specifically when navigating from the feed and back.

thomaseizinger commented 4 years ago

Somehow the scroll restoration is inverted ...