Handle situations when webServerPort is not accessible

nobuhito / vscode.printcode

PrintCode added printing function to VS Code!!

MIT License

73 stars 26 forks source link

Closed janilahti closed 6 years ago

janilahti commented 6 years ago

Show notification if error occurs when binding to webServerPort.

After merging, #4 can be closed.

Tested on Windows and Ubuntu.

nobuhito commented 6 years ago

I have also tested it on Windows, but VSCode can not get Error. I will also test it with macOS.

Can you upload a screen shot showing showInformationMessage? I will merge if I can confirm the fix with that image.

janilahti commented 6 years ago

This screenshot is on Windows when port specified in PrintCode settings clashes with a used port: printcode-windows-port-error

On linux (and I guess on macOS, too) you'd get EADDRINUSE in this kind of situation, but Windows seems to give EACCES.

nobuhito commented 6 years ago

Thank you very much! It was confirmed with macOS. Merge and let me release it.