nocarryr / rtlsdr-wwb-scanner

RF Scanner and Exporter for use with Shure Wireless Workbench
GNU General Public License v2.0
30 stars 5 forks source link

numpy update breaks scan #13

Closed DiggiD closed 1 year ago

DiggiD commented 1 year ago

phase_rot = np.fromiter(iter_phase(), dtype=np.float) Attribute Error: Module 'numpy' has no attribute 'float'

nocarryr commented 1 year ago

Good catch! I've noticed numpy removed the generic float and int dtype aliases in working on other projects.

https://github.com/nocarryr/rtlsdr-wwb-scanner/blob/eb57fa740b487e6ae85cf122031f042abae0d103/wwb_scanner/scanner/sample_processing.py#L105

Afaik, the line above can be changed to:

phase_rot = np.fromiter(iter_phase(), dtype=np.float64)

If you'd like to drop that in and test it out, I'd gladly except a pull request

DiggiD commented 1 year ago

done, tested, works!

sending pull request