nochowderforyou / clams

Clam Project
MIT License
62 stars 58 forks source link

typo in 'reason' string #135

Closed dooglus closed 9 years ago

dooglus commented 9 years ago

In main.cpp:

// Disallow large transaction comments
if (tx.strCLAMSpeech.length() > MAX_TX_COMMENT_LEN) {
    reason = "tx-comment-to-large";

That should be "too" large.

Is the reason string used for anything that now expects it to be spelled that way, or can we fix it?

l0rdicon commented 9 years ago

Its not used as a check anywheres no. It can safely be changed to tx-comment-too-large

dooglus commented 9 years ago

I just fixed this, made a pull request, pulled it, looked for this issue and saw that it was closed already.

Did you mean to close it?

Edit: I mean, if we close issues without fixing them we lose visibility of them.

dooglus commented 9 years ago

Fixed in #144.