search

nochowderforyou / clams

Clam Project
MIT License
62 stars 58 forks source link

version numbers defined in two places #139

Open dooglus opened 9 years ago

dooglus commented 9 years ago

v1.4.5 of the client identifies itself using the string "/Satoshi:1.4.4/" which makes it impossible to block connections from just v1.4.4.

The cause of the problem is that when v1.4.5 was released, the version was bumped in src/clientversion.h but not in configure.ac, where it still says:

define(_CLIENT_VERSION_REVISION, 4)

Is it necessary to have the version number components defined in two different files? It seems like it's just asking for this kind of problem to happen.

I recently tagged v1.4.6 and looked at v1.4.5 to see which files needed editing to bump the version - so I got it wrong as well. Should I move the v1.4.6 tag? Or go straight to v1.4.7 and get it right this time?

l0rdicon commented 9 years ago

Were really just following the bitcoin conventions with the build system. autotools needs the version for configuring and creating the make files and the source needs access to it as well.

Its actually in a 3rd place also, setup.msi for creating the setup files for windows.

If you know of a way to make it available everywhere it needs to be from a single place, I'm all for it

creativecuriosity commented 8 years ago

Would make more sense to have it defined in a single place to prevent this longstanding problem with missing/incorrect version numbers everywhere.

Lacking that, we need an established step by step checkbox list to go down for releases.