nochowderforyou / clams

Clam Project
MIT License
62 stars 58 forks source link

feature suggestion: like -creditstakestoaccounts but only for some stakes #258

Closed dooglus closed 8 years ago

dooglus commented 8 years ago

The default behaviour of the CLAM client when coins stake, is to credit the reward to the "" account, no matter which account the staking address belongs to.

If you specify -creditstakestoaccounts then staking rewards are credited to the account of the address which stakes.

We need something between these two, for the case where -staketo or -rewardto is used in a wallet we don't own, but specifies an address we do own as the recipient of the stake or reward.

One guy is using -rewardto in his local client to specifying his JD deposit address as the recipient of the staking rewards only. Those "deposits" aren't being credited to his account, and also aren't showing up in "getstakedbyaddress *" output.

I don't want deposits which stake after being deposited to count as crediting the account they belong to, but I do want deposits made as part of a stake to count. I guess we need a new flag for this. Or perhaps it should just be the default behaviour, I'm not sure.

dooglus commented 8 years ago

After further thought, if the transaction was staked by an external wallet, we should treat any outputs which hit our wallet just as if they were regular deposits. We don't care whether the output is the result of a staking transaction or not, it's just a deposit to us.

I will make it so.

dooglus commented 8 years ago

61d0222 implements this.