noclocks / dns

DNS Records Managed via dnscontrol
https://docs.noclocks.dev/dns/
The Unlicense
3 stars 1 forks source link

[Bug]: Redo all necessary DNS records reverted by other PRs #65

Closed jimbrig closed 3 months ago

jimbrig commented 3 months ago

@phoward38 when you merged the various pull requests (#59 #60 #61 #62 #63 and #64), you removed all the work I did yesterday for some pretty advanced DNS records.

For example, in PR #59 's DNSControl GitHub Workflow Preview Output:

image

Notice that the following changes occurred:


I will create issues and PRs and re-do everything.

phoward38 commented 3 months ago

@jimbrig I can redo it since I removed them. Not sure how that happened since I didn't touch those records.

jimbrig commented 3 months ago

No worries I've got it all locally on my other laptop and will re-implement adding docs as I go

jimbrig commented 3 months ago

Going to add testing suite against the records also with an automated GHA workflow and merge protection to help in the future also

jimbrig commented 3 months ago

@phoward38 can you provide insights into the following from above?

1. CNAME record changed from hixie to pixie (not sure about this one)

DNS Lookups:

2. Not sure about the new testimonials sub-domain? what is senja.io?

Not seeing this anymore as the current record is:

// CNAME Records - Testimonials
, CNAME("testimonials", "cname.testimonial.to.")

but if you look at your commit from the development pull request, you'll see that's where it got changed initially and was in turn reverted back here.

phoward38 commented 3 months ago
jimbrig commented 3 months ago

Cool