search

noconnor / JUnitPerf

API performance testing framework built using JUnit
Apache License 2.0
68 stars 18 forks source link

Missing ";" in HTML report template #122

Closed ewesten closed 3 weeks ago

ewesten commented 3 weeks ago

Hello,

generated HTML reports are displayed with JS errors:

Uncaught SyntaxError: Unexpected identifier 'link'

and chart is not displayed and CSV export is not working.

As far as I can tell, there is a missing ";" in https://github.com/noconnor/JUnitPerf/blob/master/junitperf-core/src/main/resources/templates/report.template#L83

Manually adding it in the generated HTML fixes the error on my side.

Regards, Eric

noconnor commented 3 weeks ago

Thanks @ewesten Should be fixed in 1.37.0 - maven release pipeline running now