Closed noconnor closed 1 year ago
I made a test and it worked with Java 17. Just a little thing from the report, this part of code:
{% set colour = (context.isErrorThresholdAchieved) ? "#2b67a4" : "#d9534f" %}
Is seen in the report, I supossed is not replaced.
I made a test and it worked with Java 17. Just a little thing from the report, this part of code:
{% set colour = (context.isErrorThresholdAchieved) ? "#2b67a4" : "#d9534f" %}
Is seen in the report, I supossed is not replaced.
That was my mistake, I created my own template and let this code inside. Btw the template changing works without problem, so I added it to the documentation and created a pull request it with. Thanks.
Thanks for your help Will. I'll do a small amount of tidy up on this PR, merge your doc changes into this branch and do a release tomorrow.
Merging #87 (7721ede) into master (4ec8782) will increase coverage by
0.93%
. The diff coverage is96.93%
.:exclamation: Current head 7721ede differs from pull request most recent head 43ef008. Consider uploading reports for the commit 43ef008 to get more accurate results
@@ Coverage Diff @@
## master #87 +/- ##
============================================
+ Coverage 91.65% 92.58% +0.93%
- Complexity 239 287 +48
============================================
Files 21 23 +2
Lines 599 742 +143
Branches 44 63 +19
============================================
+ Hits 549 687 +138
- Misses 44 47 +3
- Partials 6 8 +2
Impacted Files | Coverage Δ | |
---|---|---|
...tperf/reporting/providers/utils/ViewProcessor.java | 94.11% <94.11%> (ø) |
|
...tperf/reporting/providers/HtmlReportGenerator.java | 95.31% <95.16%> (-4.69%) |
:arrow_down: |
.../junitperf/reporting/providers/utils/ViewData.java | 98.80% <98.80%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Fixes #86
Proposed Changes
To test fix:
mvn clean install -Dgpg.skip
1.25.0-SNAPSHOT