search

noctuid / link-hint.el

Pentadactyl-like Link Hinting in Emacs with Avy
GNU General Public License v3.0
160 stars 22 forks source link

Add org-roam link type #184

Closed dit7ya closed 3 years ago

dit7ya commented 3 years ago

Solves #180.

noctuid commented 3 years ago

Is there a benefit to adding a new link type? If not could, you just add more to the :vars section of the org-link type?

dit7ya commented 3 years ago

Hey, I am figuring out that link-hint works without any extra setup for regular org-roam links. However, it does not work with org links in org-journal mode without the patch I submitted. So, maybe it is not about org-roam, rather about org-journal. Let me investigate it further and please don't merge this PR in the meantime.

dit7ya commented 3 years ago

Okay, so it was about org-journal only, and adding org-journal-mode to the :vars solves it. I am closing this PR and opening another one with correct title.

akirak commented 3 years ago

Hey, I am figuring out that link-hint works without any extra setup for regular org-roam links. However, it does not work with org links in org-journal mode without the patch I submitted. So, maybe it is not about org-roam, rather about org-journal. Let me investigate it further and please don't merge this PR in the meantime.

org-journal defines org-journal-mode which is derived from org-mode, so you will have to add org-journal-mode to :vars.