search

noctuid / link-hint.el

Pentadactyl-like Link Hinting in Emacs with Avy
GNU General Public License v3.0
162 stars 22 forks source link

Add fanyi-mode to overlay-button vars #201

Closed akirak closed 2 years ago

akirak commented 2 years ago

This PR adds support for fanyi.el. It helps looking up a word in multiple dictionaries quickly.

noctuid commented 2 years ago

Just to confirm, this doesn't work as a button but must be the overlay-button type?

akirak commented 2 years ago

this doesn't work as a button but must be the overlay-button type?

Yes, it doesn't work without this patch and works with the patch. Both text links and pronunciation icons work.

Should I add fanyi-mode to :not-vars property of link-hint-define-type 'button?

noctuid commented 2 years ago

Should I add fanyi-mode to :not-vars property of link-hint-define-type 'button?

Yes

akirak commented 2 years ago

Fixed it. Thanks.

noctuid commented 2 years ago

Great, thanks!